[webkit-reviews] review granted: [Bug 192570] [iOS] Support dropping contact card data (public.vcard) in editable content : [Attachment 357085] Fix 32-bit macOS build

[bugzilla-daemon at webkit.org]

Tim Horton <thorton at apple.com> has granted Wenson Hsieh
<wenson_hsieh at apple.com>'s request for review:
Bug 192570: [iOS] Support dropping contact card data (public.vcard) in editable
content
https://bugs.webkit.org/show_bug.cgi?id=192570

Attachment 357085: Fix 32-bit macOS build

https://bugs.webkit.org/attachment.cgi?id=357085&action=review




--- Comment #5 from Tim Horton <thorton at apple.com> ---
Comment on attachment 357085
  --> https://bugs.webkit.org/attachment.cgi?id=357085
Fix 32-bit macOS build

View in context: https://bugs.webkit.org/attachment.cgi?id=357085&action=review

> Tools/TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:28
> +#if WK_API_ENABLED && !PLATFORM(WATCHOS) && !PLATFORM(TVOS)

isn't this just PLATFORM(IOS) now?

WK_API_ENABLED is always true there, and that excludes watch and tv

> Tools/TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:1851
> +    [contact setFamilyName:@"Bitdiddle"];

🤨