[webkit-reviews] review requested: [Bug 192229] [GStreamer][EME][ClearKey] Request keys from CDMInstance rather than passing via bus messages : [Attachment 357229] Patch

[bugzilla-daemon at webkit.org]

Charlie Turner <cturner at igalia.com> has asked  for review:
Bug 192229: [GStreamer][EME][ClearKey] Request keys from CDMInstance rather
than passing via bus messages
https://bugs.webkit.org/show_bug.cgi?id=192229

Attachment 357229: Patch

https://bugs.webkit.org/attachment.cgi?id=357229&action=review




--- Comment #15 from Charlie Turner <cturner at igalia.com> ---
Created attachment 357229

  --> https://bugs.webkit.org/attachment.cgi?id=357229&action=review

Patch

Move back to multi-decryptor architecture, and use CDM downcasting to avoid
making any changes to CDMInstance. This avoids needing to touch the base class,
and instead moves us to relying on the CDMInstance for key management, rather
than key IDs extracted from init data that is not possible in general. Still
think it would be a good idea for CDMInstance to have an availableKeys() method
or something similar as explained above, but to unblock here, this alternative
is now propsed