[webkit-reviews] review granted: [Bug 192647] The JSC shell should listen for memory pressure events and respond to them : [Attachment 357197] patch

[bugzilla-daemon at webkit.org]

Keith Miller <keith_miller at apple.com> has granted Saam Barati
<sbarati at apple.com>'s request for review:
Bug 192647: The JSC shell should listen for memory pressure events and respond
to them
https://bugs.webkit.org/show_bug.cgi?id=192647

Attachment 357197: patch

https://bugs.webkit.org/attachment.cgi?id=357197&action=review




--- Comment #4 from Keith Miller <keith_miller at apple.com> ---
Comment on attachment 357197
  --> https://bugs.webkit.org/attachment.cgi?id=357197
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=357197&action=review

r=me. Can we do this for API users too?

> Source/WTF/wtf/MemoryPressureHandler.cpp:310
> +    dispatch_retain(queue);
> +    if (m_dispatchQueue)
> +	   dispatch_release(m_dispatchQueue);
> +    m_dispatchQueue = queue;

If there's an easy way to assert this isn't called after installation I think
we should do so. Otherwise maybe put a comment.