[webkit-reviews] review granted: [Bug 192622] [GTK][WPE] Fix forwarding webkit socket to flatpak sandbox : [Attachment 357126] Patch

[bugzilla-daemon at webkit.org]

Michael Catanzaro <mcatanzaro at igalia.com> has granted Patrick Griffis
<pgriffis at igalia.com>'s request for review:
Bug 192622: [GTK][WPE] Fix forwarding webkit socket to flatpak sandbox
https://bugs.webkit.org/show_bug.cgi?id=192622

Attachment 357126: Patch

https://bugs.webkit.org/attachment.cgi?id=357126&action=review




--- Comment #7 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Comment on attachment 357126
  --> https://bugs.webkit.org/attachment.cgi?id=357126
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=357126&action=review

Thanks for fixing Carlos's suggestions. LGTM, only one nit.

> Source/WebKit/UIProcess/Launcher/glib/FlatpakLauncher.h:39
> +GRefPtr<GSubprocess> flatpakSpawn(GSubprocessLauncher*, const
WebKit::ProcessLauncher::LaunchOptions&, char** argv, int, GError**);

You should name the int parameter here. We use names in header files when the
name would add meaning. E.g. we don't name the GSubprocessLauncher launcher or
the LaunchOptions launchOptions, since that doesn't help readability. But the
int should be named childProcessSocket, because that does improve readability.