[webkit-reviews] review granted: [Bug 192620] [DFG][FTL] Add NewSymbol : [Attachment 357123] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Dec 12 10:10:33 PST 2018


Saam Barati <sbarati at apple.com> has granted Yusuke Suzuki
<yusukesuzuki at slowstart.org>'s request for review:
Bug 192620: [DFG][FTL] Add NewSymbol
https://bugs.webkit.org/show_bug.cgi?id=192620

Attachment 357123: Patch

https://bugs.webkit.org/attachment.cgi?id=357123&action=review




--- Comment #3 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 357123
  --> https://bugs.webkit.org/attachment.cgi?id=357123
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=357123&action=review

> Source/JavaScriptCore/ChangeLog:9
> +	   NewSymbol code faster. Rather than that, this patch intends to offer
SpecSymbol type information into DFG's

Do you think it could be worth inlining the allocation for this in another
patch?

> Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp:9662
> +    // Known String.

You should assert instead of comment


More information about the webkit-reviews mailing list