[webkit-reviews] review denied: [Bug 192375] HTTPS Upgrade: Figure out if/how to tell clients that the HTTPS upgrade happened : [Attachment 357091] Patch

[bugzilla-daemon at webkit.org]

Chris Dumez <cdumez at apple.com> has denied Vivek Seth <v_seth at apple.com>'s
request for review:
Bug 192375: HTTPS Upgrade: Figure out if/how to tell clients that the HTTPS
upgrade happened
https://bugs.webkit.org/show_bug.cgi?id=192375

Attachment 357091: Patch

https://bugs.webkit.org/attachment.cgi?id=357091&action=review




--- Comment #49 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 357091
  --> https://bugs.webkit.org/attachment.cgi?id=357091
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=357091&action=review

> Source/WebCore/platform/network/mac/WebCoreURLResponse.mm:350
> +    return ResourceResponse::syntheticRedirectResponse(URL([currentRequest
URL]), URL([newRequest URL])).nsURLResponse();

You have a lifetime problem here, the NSURLResponse you are returning is owned
by the ResourceResponse returned by syntheticRedirectResponse(), which is a
temporary. This is likely the cause of the crash.