[webkit-reviews] review granted: [Bug 192615] [BigInt] Simplify boolean context evaluation by leveraging JSString::offsetOfLength() == JSBigInt::offsetOfLength() : [Attachment 357106] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Dec 12 00:21:25 PST 2018
Saam Barati <sbarati at apple.com> has granted Yusuke Suzuki
<yusukesuzuki at slowstart.org>'s request for review:
Bug 192615: [BigInt] Simplify boolean context evaluation by leveraging
JSString::offsetOfLength() == JSBigInt::offsetOfLength()
https://bugs.webkit.org/show_bug.cgi?id=192615
Attachment 357106: Patch
https://bugs.webkit.org/attachment.cgi?id=357106&action=review
--- Comment #4 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 357106
--> https://bugs.webkit.org/attachment.cgi?id=357106
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=357106&action=review
> Source/JavaScriptCore/ftl/FTLAbstractHeapRepository.cpp:64
> + , JSBigInt_length(JSString_length)
Can we add a new field called something like JSBigIntOrString_length then when
we load from this in that scenario we can use that field?
More information about the webkit-reviews
mailing list