[webkit-reviews] review granted: [Bug 192482] PSON logic gets confused by concurrent decidePolicyForNavigationAction requests : [Attachment 356814] Patch

[bugzilla-daemon at webkit.org]

Antti Koivisto <koivisto at iki.fi> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 192482: PSON logic gets confused by concurrent
decidePolicyForNavigationAction requests
https://bugs.webkit.org/show_bug.cgi?id=192482

Attachment 356814: Patch

https://bugs.webkit.org/attachment.cgi?id=356814&action=review




--- Comment #9 from Antti Koivisto <koivisto at iki.fi> ---
Comment on attachment 356814
  --> https://bugs.webkit.org/attachment.cgi?id=356814
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=356814&action=review

The additional asynchronous steps make the code even harder to follow, which is
sad. But this does solve a real problem.

> Source/WebKit/ChangeLog:11
> +	   It is possible to get 2 parallel decidePolicyForNavigationAction()
requests from the
> +	   WebProcess when a new load is started before responding to the
existing policy
> +	   decision. This would lead to several issues with regards to PSON:

Could we alternatively avoid this issue by not calling policy delegates for
about:blank loads for suspension?