[webkit-reviews] review granted: [Bug 192375] HTTPS Upgrade: Figure out if/how to tell clients that the HTTPS upgrade happened : [Attachment 357009] Patch

[bugzilla-daemon at webkit.org]

Chris Dumez <cdumez at apple.com> has granted Vivek Seth <v_seth at apple.com>'s
request for review:
Bug 192375: HTTPS Upgrade: Figure out if/how to tell clients that the HTTPS
upgrade happened
https://bugs.webkit.org/show_bug.cgi?id=192375

Attachment 357009: Patch

https://bugs.webkit.org/attachment.cgi?id=357009&action=review




--- Comment #37 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 357009
  --> https://bugs.webkit.org/attachment.cgi?id=357009
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=357009&action=review

r=me with a couple of nits. We should also definitely fix GTK build.

> Source/WebKit/NetworkProcess/NetworkLoadChecker.h:46
> +    enum class LoadType { MainFrame, Other };

enum class LoadType : bool { MainFrame, Other };

> Source/WebKit/NetworkProcess/NetworkResourceLoader.cpp:190
> +		       willSendRedirectedRequest(WTFMove(triplet.request),
WTFMove(triplet.redirectRequest), WTFMove(triplet.redirectResponse));

You may need this-> here to to fix GTK build.

> Source/WebKit/NetworkProcess/PingLoad.cpp:65
> +		   this->loadRequest(WTFMove(triplet.redirectRequest));

This think this should be an ASSERT_NOT_REACHED(). We should never be
simulating redirects for Ping Loads.