[webkit-reviews] review granted: [Bug 192335] CS Painting API should support multiple worklets. : [Attachment 356973] Patch

[bugzilla-daemon at webkit.org]

Dean Jackson <dino at apple.com> has granted Justin Michaud
<justin_michaud at apple.com>'s request for review:
Bug 192335: CS Painting API should support multiple worklets.
https://bugs.webkit.org/show_bug.cgi?id=192335

Attachment 356973: Patch

https://bugs.webkit.org/attachment.cgi?id=356973&action=review




--- Comment #5 from Dean Jackson <dino at apple.com> ---
Comment on attachment 356973
  --> https://bugs.webkit.org/attachment.cgi?id=356973
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=356973&action=review

> LayoutTests/fast/css-custom-paint/multiple-worklets-isolation.html:29
> +    console.log("Paint 1: " + typeof(shouldOnlyBeInCode1));

Did you want to leave this in?

> LayoutTests/fast/css-custom-paint/multiple-worklets-isolation.html:34
> +    if (typeof(shouldOnlyBeInCode1) == 'function') {
> +	 ctx.fillStyle = 'green';
> +    } else {
> +	 ctx.fillStyle = 'red';
> +    }

ctx.fillStyle = (typeof(shouldOnlyBeInCode1) == 'function') ? 'green' : 'red';

> LayoutTests/fast/css-custom-paint/multiple-worklets-isolation.html:43
> +    if (typeof(shouldOnlyBeInCode1) == 'undefined') {

Nice!