[webkit-reviews] review denied: [Bug 192375] HTTPS Upgrade: Figure out if/how to tell clients that the HTTPS upgrade happened : [Attachment 356978] Patch

[bugzilla-daemon at webkit.org]

Alex Christensen <achristensen at apple.com> has denied Vivek Seth
<v_seth at apple.com>'s request for review:
Bug 192375: HTTPS Upgrade: Figure out if/how to tell clients that the HTTPS
upgrade happened
https://bugs.webkit.org/show_bug.cgi?id=192375

Attachment 356978: Patch

https://bugs.webkit.org/attachment.cgi?id=356978&action=review




--- Comment #29 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 356978
  --> https://bugs.webkit.org/attachment.cgi?id=356978
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=356978&action=review

> Source/WebKit/NetworkProcess/NetworkLoadChecker.cpp:209
> +    if (m_requestLoadType != LoadType::MainFrame)
> +	   return;

Why don't we want to upgrade sub resource requests?

> Source/WebKit/NetworkProcess/NetworkLoadChecker.h:64
> +    void check(WebCore::ResourceRequest&&,
WebCore::ContentSecurityPolicyClient*, ValidationHandler&&);

This is a bad name.