[webkit-reviews] review granted: [Bug 8644] XMLHttpRequest removes spaces from content-types before processing : [Attachment 356949] Patch

[bugzilla-daemon at webkit.org]

Chris Dumez <cdumez at apple.com> has granted Rob Buis <rbuis at igalia.com>'s
request for review:
Bug 8644: XMLHttpRequest removes spaces from content-types before processing
https://bugs.webkit.org/show_bug.cgi?id=8644

Attachment 356949: Patch

https://bugs.webkit.org/attachment.cgi?id=356949&action=review




--- Comment #18 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 356949
  --> https://bugs.webkit.org/attachment.cgi?id=356949
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=356949&action=review

r=me with comments.

> Source/WebCore/platform/network/HTTPParsers.cpp:328
> +	   if (c == ',' || c == ';')

Why is this in the comma section?  ';' is not about allow multiple values. I
think we should move the ';'...

> Source/WebCore/platform/network/HTTPParsers.cpp:331
> +	   if (c != '\t' && c != ' ')

... to here.