[webkit-reviews] review granted: [Bug 192449] [meta][WebKit] Remove using namespace WebCore and WebKit in the global scope for unified source builds : [Attachment 356872] patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted chris fleizach
<cfleizach at apple.com>'s request for review:
Bug 192449: [meta][WebKit] Remove using namespace WebCore and WebKit in the
global scope for unified source builds
https://bugs.webkit.org/show_bug.cgi?id=192449

Attachment 356872: patch

https://bugs.webkit.org/attachment.cgi?id=356872&action=review




--- Comment #17 from Darin Adler <darin at apple.com> ---
Comment on attachment 356872
  --> https://bugs.webkit.org/attachment.cgi?id=356872
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=356872&action=review

> Source/WebKit/UIProcess/ios/WKContentView.mm:65
>  using namespace WebKit;

This is still a potential problem. Needs to eventually be removed.

> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:145
>  using namespace WebKit;

This is still a potential problem. Needs to eventually be removed.

> Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenWindowControllerIOS.mm:61
> +using namespace WebKit;

This is still a potential problem. Needs to eventually be removed.

> Source/WebKit/WebProcess/Cache/WebCacheStorageConnection.cpp:40
>  using namespace WebKit::CacheStorage;

This is now a bit peculiar. Should probably just say "using namespace
CacheStorage".

> Source/WebKit/WebProcess/WebPage/mac/WKAccessibilityWebPageObjectMac.mm:51
>  using namespace WebKit;

This is still a potential problem. Needs to eventually be removed.