[webkit-reviews] review granted: [Bug 192521] Animated scrolling on Google Maps scrolls the page in addition to moving the map : [Attachment 356846] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Dec 7 20:20:49 PST 2018


Sam Weinig <sam at webkit.org> has granted Tim Horton <thorton at apple.com>'s
request for review:
Bug 192521: Animated scrolling on Google Maps scrolls the page in addition to
moving the map
https://bugs.webkit.org/show_bug.cgi?id=192521

Attachment 356846: Patch

https://bugs.webkit.org/attachment.cgi?id=356846&action=review




--- Comment #3 from Sam Weinig <sam at webkit.org> ---
Comment on attachment 356846
  --> https://bugs.webkit.org/attachment.cgi?id=356846
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=356846&action=review

> Source/WebKit/ChangeLog:14
> +	   * UIProcess/ios/WKKeyboardScrollingAnimator.mm:
> +	   (-[WKKeyboardScrollViewAnimator rubberbandableDirections]):
> +	   Only do keyboard-based rubber-banding in directions that we can
actually
> +	   scroll, not directions we can only finger-rubber-band in. This
effectively
> +	   means keyboard scrolling will ignore "alwaysBounce{Vertical,
Horizontal}".

Is there any way to test this?


More information about the webkit-reviews mailing list