[webkit-reviews] review denied: [Bug 192509] Add SPI to allow the client to set the user-agent at frame level, from the UIProcess : [Attachment 356829] Patch

[bugzilla-daemon at webkit.org]

Alex Christensen <achristensen at apple.com> has denied Chris Dumez
<cdumez at apple.com>'s request for review:
Bug 192509: Add SPI to allow the client to set the user-agent at frame level,
from the UIProcess
https://bugs.webkit.org/show_bug.cgi?id=192509

Attachment 356829: Patch

https://bugs.webkit.org/attachment.cgi?id=356829&action=review




--- Comment #4 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 356829
  --> https://bugs.webkit.org/attachment.cgi?id=356829
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=356829&action=review

> Source/WebCore/loader/FrameLoader.cpp:2667
>  String FrameLoader::userAgent(const URL& url) const
>  {
> +    if (auto* documentLoader = activeDocumentLoader()) {

I think we will want subframes to have the same user agent as their parent?  I
think this should go to the main frame's active document loader and have a
test.