[webkit-reviews] review granted: [Bug 192514] [MediaStream] Address post-review comments after r238904 : [Attachment 356835] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Dec 7 14:19:36 PST 2018
youenn fablet <youennf at gmail.com> has granted Eric Carlson
<eric.carlson at apple.com>'s request for review:
Bug 192514: [MediaStream] Address post-review comments after r238904
https://bugs.webkit.org/show_bug.cgi?id=192514
Attachment 356835: Patch
https://bugs.webkit.org/attachment.cgi?id=356835&action=review
--- Comment #3 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 356835
--> https://bugs.webkit.org/attachment.cgi?id=356835
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=356835&action=review
> Source/WebCore/platform/graphics/cv/ImageTransferSessionVT.mm:91
> + (__bridge NSString *)kCVPixelBufferPixelFormatTypeKey :
@(m_pixelFormat),
In other parts of the code (RealtimeXXSourceCocoa, ImageDecoderAVFObjC), we put
name: value.
Not sure what the preferred style is.
More information about the webkit-reviews
mailing list