[webkit-reviews] review granted: [Bug 192511] [MediaStream] 'devicechange' event should not fire in frames that can't access capture devices : [Attachment 356832] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Dec 7 13:49:39 PST 2018

youenn fablet <youennf at gmail.com> has granted Eric Carlson
<eric.carlson at apple.com>'s request for review:
Bug 192511: [MediaStream] 'devicechange' event should not fire in frames that
can't access capture devices

Attachment 356832: Patch


--- Comment #3 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 356832
  --> https://bugs.webkit.org/attachment.cgi?id=356832

View in context: https://bugs.webkit.org/attachment.cgi?id=356832&action=review

> Source/WebKit/UIProcess/UserMediaPermissionRequestManagerProxy.cpp:103
> +	   auto accessState = originHasPersistentAccess ?
DeviceAccessState::PersistentAccess : DeviceAccessState::SessionAccess;

Do we need to send that information any longer?
It seems that just knowing that we have access is good enough now.

> +    <iframe id="camera" allow="camera"

For the sake of completeness, I would tend to add a frame with an
allow="microphone" as well.

More information about the webkit-reviews mailing list