[webkit-reviews] review granted: [Bug 192508] [iOS] Make WebGPU work with remote layer hosting : [Attachment 356827] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Dec 7 12:03:35 PST 2018
Tim Horton <thorton at apple.com> has granted Dean Jackson <dino at apple.com>'s
request for review:
Bug 192508: [iOS] Make WebGPU work with remote layer hosting
https://bugs.webkit.org/show_bug.cgi?id=192508
Attachment 356827: Patch
https://bugs.webkit.org/attachment.cgi?id=356827&action=review
--- Comment #3 from Tim Horton <thorton at apple.com> ---
Comment on attachment 356827
--> https://bugs.webkit.org/attachment.cgi?id=356827
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=356827&action=review
> Source/WebCore/platform/graphics/ca/cocoa/PlatformCALayerCocoa.mm:41
> +#if ENABLE(WEBGPU)
In its own paragraph!
> Source/WebCore/platform/graphics/ca/cocoa/PlatformCALayerCocoa.mm:46
> #if ENABLE(WEBMETAL)
Ditto
> Source/WebCore/platform/graphics/cocoa/WebGPULayer.h:38
> + float _devicePixelRatio;
Native-y code doesn't usually use the webby "devicePixelRatio" but usually
"deviceScaleFactor"
> Source/WebCore/platform/graphics/cocoa/WebGPULayer.h:43
> +- (id)init;
Why?
More information about the webkit-reviews
mailing list