[webkit-reviews] review granted: [Bug 192487] Web Inspector: Move TreeOutlineGroup coordination out of TreeElement : [Attachment 356775] Patch

[bugzilla-daemon at webkit.org]

Devin Rousso <drousso at apple.com> has granted Matt Baker <mattbaker at apple.com>'s
request for review:
Bug 192487: Web Inspector: Move TreeOutlineGroup coordination out of
TreeElement
https://bugs.webkit.org/show_bug.cgi?id=192487

Attachment 356775: Patch

https://bugs.webkit.org/attachment.cgi?id=356775&action=review




--- Comment #5 from Devin Rousso <drousso at apple.com> ---
Comment on attachment 356775
  --> https://bugs.webkit.org/attachment.cgi?id=356775
Patch

r+

I did notice some unrealted selection issues (not sure if it relates to
something that's already been filed).

* STEPS TO REPRODUCE:
1. open WebInspector
2. show the Resources tab to any JS file (starts the FormatterWorker)
3. open WebInspector2
4. set a breakpoint in WebInspector2 on `WI.showRepresentedObject
5. do something in WebInspector to trigger that pause (e.g. switch tabs or
select something in a navigation sidebar)
6. switch call frames in WebInspector2 to the last frame of the Page, and then
switch again to the FormatterWorker's Idle frame
7. step over
 => the first frame of Page and FormatterWorker's Idle frame are both selected