[webkit-reviews] review denied: [Bug 192491] [WTF] Debug build fails due conflicting abort() method : [Attachment 356789] Patch

[bugzilla-daemon at webkit.org]

Michael Catanzaro <mcatanzaro at igalia.com> has denied Adrian Perez
<aperez at igalia.com>'s request for review:
Bug 192491: [WTF] Debug build fails due conflicting abort() method
https://bugs.webkit.org/show_bug.cgi?id=192491

Attachment 356789: Patch

https://bugs.webkit.org/attachment.cgi?id=356789&action=review




--- Comment #2 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Comment on attachment 356789
  --> https://bugs.webkit.org/attachment.cgi?id=356789
Patch

I wonder why none of the bots noticed this. Or why it doesn't affect me
locally. I've done many debug builds.

This was good thinking, but unfortunately this is one of a very few headers
that get included in C (and Objective C) so we can't use namespaces here. E.g.
from EWS:

/home/buildbot/ews/WebKit/Source/JavaScriptCore/API/tests/testapi.c: In
function ‘createStringWithContentsOfFile’:
DerivedSources/ForwardingHeaders/wtf/Assertions.h:244:21: error: expected
expression before ‘:’ token
 #define CRASH() std::abort()
		     ^

I was going to suggest renaming XMLHttpRequest::abort instead, but there are
more abort()s in the codebase... NetworkResourceLoader.cpp, testbmalloc.cpp....

We could add a new conditional to check #if __cplusplus? But that would be
messier.