[webkit-reviews] review granted: [Bug 192500] [LFC] Rename formattingContext() to createFormattingContext() : [Attachment 356818] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Dec 7 10:17:20 PST 2018


zalan <zalan at apple.com> has granted Antti Koivisto <koivisto at iki.fi>'s request
for review:
Bug 192500: [LFC] Rename formattingContext() to createFormattingContext()
https://bugs.webkit.org/show_bug.cgi?id=192500

Attachment 356818: patch

https://bugs.webkit.org/attachment.cgi?id=356818&action=review




--- Comment #2 from zalan <zalan at apple.com> ---
Comment on attachment 356818
  --> https://bugs.webkit.org/attachment.cgi?id=356818
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=356818&action=review

> Source/WebCore/layout/FormattingState.h:49
> +    virtual std::unique_ptr<FormattingContext> createFormattingContext(const
Box& formattingContextRoot) = 0;

Very nice. I wonder who reviewed this originally.


More information about the webkit-reviews mailing list