[webkit-reviews] review granted: [Bug 192006] Record right offset with aligned wide instructions : [Attachment 356798] Patch

[bugzilla-daemon at webkit.org]

Yusuke Suzuki <yusukesuzuki at slowstart.org> has granted Dominik Inführ
<dinfuehr at igalia.com>'s request for review:
Bug 192006: Record right offset with aligned wide instructions
https://bugs.webkit.org/show_bug.cgi?id=192006

Attachment 356798: Patch

https://bugs.webkit.org/attachment.cgi?id=356798&action=review




--- Comment #9 from Yusuke Suzuki <yusukesuzuki at slowstart.org> ---
Comment on attachment 356798
  --> https://bugs.webkit.org/attachment.cgi?id=356798
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=356798&action=review

r=me

> Source/JavaScriptCore/bytecompiler/BytecodeGenerator.cpp:2787
> +    auto inst = m_lastInstruction;
> +    m_staticPropertyAnalyzer.createThis(dst, WTFMove(inst));

By changing the signature of `createThis` from `void createThis(RegisterID*
dst, InstructionStream::MutableRef&& instructionRef);` to `void
createThis(RegisterID* dst, InstructionStream::MutableRef instructionRef);`,
we do not need `auto inst = m_lastInstruction;` and `WTFMove` here.

> Source/JavaScriptCore/bytecompiler/BytecodeGenerator.cpp:2899
> +    auto inst = m_lastInstruction;
> +    m_staticPropertyAnalyzer.newObject(dst, WTFMove(inst));
> +

Ditto