[webkit-reviews] review granted: [Bug 192481] Injected bundle for WebKitTestRunner leaks WKTypeRef objects : [Attachment 356760] Patch v1

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted David Kilzer
(:ddkilzer) <ddkilzer at webkit.org>'s request for review:
Bug 192481: Injected bundle for WebKitTestRunner leaks WKTypeRef objects
https://bugs.webkit.org/show_bug.cgi?id=192481

Attachment 356760: Patch v1

https://bugs.webkit.org/attachment.cgi?id=356760&action=review




--- Comment #3 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 356760
  --> https://bugs.webkit.org/attachment.cgi?id=356760
Patch v1

View in context: https://bugs.webkit.org/attachment.cgi?id=356760&action=review

> Tools/WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:125
> +    WKRetainPtr<WKDictionaryRef> initializationDictionary(AdoptWK,
static_cast<WKDictionaryRef>(result));

Can we make a version of WKBundlePostSynchronousMessage that is more explicit
that the result is retained? At least add a comment in WKBundle.h documenting
this above WKBundlePostSynchronousMessage.