[webkit-reviews] review granted: [Bug 192377] We should ignore minimumEffectiveDeviceWidth if the page specifies device-width in viewport meta-tag. : [Attachment 356613] Address review comments.

[bugzilla-daemon at webkit.org]

Tim Horton <thorton at apple.com> has granted Yongjun Zhang
<yongjun_zhang at apple.com>'s request for review:
Bug 192377: We should ignore minimumEffectiveDeviceWidth if the page specifies
device-width in viewport meta-tag.
https://bugs.webkit.org/show_bug.cgi?id=192377

Attachment 356613: Address review comments.

https://bugs.webkit.org/attachment.cgi?id=356613&action=review




--- Comment #6 from Tim Horton <thorton at apple.com> ---
Comment on attachment 356613
  --> https://bugs.webkit.org/attachment.cgi?id=356613
Address review comments.

View in context: https://bugs.webkit.org/attachment.cgi?id=356613&action=review

> Source/WebCore/page/ViewportConfiguration.cpp:351
> +ViewportConfiguration::Parameters
ViewportConfiguration::standardWebpageParameters()

We talked about the name of this offline. You might also consider sharing some
code with the function above.