[webkit-reviews] review granted: [Bug 187554] [iOS] WKWebView should match UITextView behavior when editing text with an RTL keyboard : [Attachment 356736] First pass

[bugzilla-daemon at webkit.org]

Tim Horton <thorton at apple.com> has granted Wenson Hsieh
<wenson_hsieh at apple.com>'s request for review:
Bug 187554: [iOS] WKWebView should match UITextView behavior when editing text
with an RTL keyboard
https://bugs.webkit.org/show_bug.cgi?id=187554

Attachment 356736: First pass

https://bugs.webkit.org/attachment.cgi?id=356736&action=review




--- Comment #7 from Tim Horton <thorton at apple.com> ---
Comment on attachment 356736
  --> https://bugs.webkit.org/attachment.cgi?id=356736
First pass

View in context: https://bugs.webkit.org/attachment.cgi?id=356736&action=review

> Source/WebKit/UIProcess/WebPageProxy.cpp:1875
> +    if (isValid())

This is a surprising and bizarre pattern! Would much prefer if these were all
early returns, despite being more lines.

> Source/WebKit/UIProcess/ios/WebPageProxyIOS.mm:911
> +    m_waitingForPostLayoutEditorStateUpdateAfterFocusingElement = false;

Do we get here if the process dies? (otherwise, you might need to reset this
there too?

> Tools/WebKitTestRunner/cocoa/TestControllerCocoa.mm:176
> +
> +    if (options.editable)
> +	   m_mainWebView->setEditable(true);

How did we not have this before