[webkit-reviews] review granted: [Bug 192465] [BFC][MarginCollapsing] Extend margin collapsing rules. : [Attachment 356727] Patch

[bugzilla-daemon at webkit.org]

Antti Koivisto <koivisto at iki.fi> has granted zalan <zalan at apple.com>'s request
for review:
Bug 192465: [BFC][MarginCollapsing] Extend margin collapsing rules.
https://bugs.webkit.org/show_bug.cgi?id=192465

Attachment 356727: Patch

https://bugs.webkit.org/attachment.cgi?id=356727&action=review




--- Comment #2 from Antti Koivisto <koivisto at iki.fi> ---
Comment on attachment 356727
  --> https://bugs.webkit.org/attachment.cgi?id=356727
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=356727&action=review

> Source/WebCore/layout/blockformatting/BlockFormattingContext.h:108
> +	       static bool marginTopCollapsesWithParent(const LayoutState&,
const Box&);
> +	       static bool marginTopCollapsesWithSibling(const Box&);
> +	       static bool marginBottomCollapsesWithSibling(const Box&);
> +	       static bool marginsCollapseThrough(const Box&);

Word 'margin' in these is a bit redundant.