[webkit-reviews] review granted: [Bug 192353] Web Inspector: REGRESSION(r238602): Elements: collapsing a DOM node with the left arrow doesn't work : [Attachment 356543] Patch

[bugzilla-daemon at webkit.org]

Devin Rousso <drousso at apple.com> has granted Matt Baker <mattbaker at apple.com>'s
request for review:
Bug 192353: Web Inspector: REGRESSION(r238602): Elements: collapsing a DOM node
with the left arrow doesn't work
https://bugs.webkit.org/show_bug.cgi?id=192353

Attachment 356543: Patch

https://bugs.webkit.org/attachment.cgi?id=356543&action=review




--- Comment #10 from Devin Rousso <drousso at apple.com> ---
Comment on attachment 356543
  --> https://bugs.webkit.org/attachment.cgi?id=356543
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=356543&action=review

r=me

> Source/WebInspectorUI/UserInterface/Views/TreeElement.js:535
> +	   if (!this.treeOutline || !this.selected)

We should add an assert here, just so that we can observe other
non-multiple-selection callers and make sure we aren't generating any new
issues:

    console.assert(this.treeOutline.allowsMultipleSelection ||
this.treeOutline.selectedTreeElement === this);

or even:

    console.assert(this.treeOutline.selectedTreeElements.includes(this));