[webkit-reviews] review granted: [Bug 192373] AX: Support keyboard access preference for iOS in WebKit : [Attachment 356563] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Dec 5 12:53:53 PST 2018

Tim Horton <thorton at apple.com> has granted chris fleizach
<cfleizach at apple.com>'s request for review:
Bug 192373: AX: Support keyboard access preference for iOS in WebKit

Attachment 356563: patch


--- Comment #9 from Tim Horton <thorton at apple.com> ---
Comment on attachment 356563
  --> https://bugs.webkit.org/attachment.cgi?id=356563

View in context: https://bugs.webkit.org/attachment.cgi?id=356563&action=review

Agree with Dan's other comments.

>> Source/WebKit/UIProcess/mac/WKFullKeyboardAccessWatcher.mm:44
>> +#endif
> This file is meant to be Mac-only as indicated by its presence in
Source/WebKit/UIProcess/mac. We should move this file and the associated header
to Source/WebKit/UIProcess/cocoa to reflect that it now contains code for both
Mac and iOS.

I just added a AccessibilitySupportSPI file, this should be there instead.

More information about the webkit-reviews mailing list