[webkit-reviews] review denied: [Bug 192384] [PlayStation] Enable WebCore : [Attachment 356557] Patch

[bugzilla-daemon at webkit.org]

Fujii Hironori <Hironori.Fujii at sony.com> has denied Don Olmstead
<don.olmstead at sony.com>'s request for review:
Bug 192384: [PlayStation] Enable WebCore
https://bugs.webkit.org/show_bug.cgi?id=192384

Attachment 356557: Patch

https://bugs.webkit.org/attachment.cgi?id=356557&action=review




--- Comment #6 from Fujii Hironori <Hironori.Fujii at sony.com> ---
Comment on attachment 356557
  --> https://bugs.webkit.org/attachment.cgi?id=356557
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=356557&action=review

> Source/WebCore/ChangeLog:12
> +	   * platform/generic/EventLoopGeneric.cpp: Added.

This patch adds some files in platform/generic directory. See Bug 189428
Comment 3.

> Source/WebCore/PlatformPlayStation.cmake:92
> +)

I think it is a good practice to add ${NGHTTP2_INCLUDE_DIRS} and
${PIXMAN_INCLUDE_DIRS} to match with libs.

> Source/WebCore/PlatformPlayStation.cmake:97
> +    ${NETWORK_LIBRARY}

Where is NETWORK_LIBRARY defined?

> Source/WebCore/platform/playstation/PlatformScreenPlayStation.cpp:60
> +    return { 0.0f, 0.0f, 1920.0f, 1080.0f };

https://webkit.org/code-style-guidelines/#float-suffixes

> Source/WebCore/platform/playstation/PlatformScreenPlayStation.cpp:66
> +    return { 0.0f, 0.0f, 1920.0f, 1080.0f };

https://webkit.org/code-style-guidelines/#float-suffixes