[webkit-reviews] review granted: [Bug 192379] [MediaStream] Cleanup up Mac screen capture class : [Attachment 356532] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Dec 4 18:44:01 PST 2018


youenn fablet <youennf at gmail.com> has granted Eric Carlson
<eric.carlson at apple.com>'s request for review:
Bug 192379: [MediaStream] Cleanup up Mac screen capture class
https://bugs.webkit.org/show_bug.cgi?id=192379

Attachment 356532: Patch

https://bugs.webkit.org/attachment.cgi?id=356532&action=review




--- Comment #3 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 356532
  --> https://bugs.webkit.org/attachment.cgi?id=356532
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=356532&action=review

> Source/WebCore/ChangeLog:12
> +	   (WebCore::DisplayCaptureManagerCocoa::captureDevices): Initialize
Display devices first.

Maybe document why we need to do this

> Source/WebCore/platform/mediastream/mac/ScreenDisplayCaptureSourceMac.mm:156
>	       weakThis->frameAvailable(status, displayTime, frameSurface,
updateRef);

This is existing code but the weakThis check is not thread safe here. weakThis
may be dead between if and next call.

> Source/WebCore/platform/mediastream/mac/ScreenDisplayCaptureSourceMac.mm:-167
> -	   });

Do we need the call to frameAvailable to be in a background thread?


More information about the webkit-reviews mailing list