[webkit-reviews] review granted: [Bug 192241] [ews-app] Run BugzillaPatchFetcher periodically : [Attachment 356393] Proposed patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Dec 4 11:01:56 PST 2018


Lucas Forschler <lforschler at apple.com> has granted Aakash Jain
<aakash_jain at apple.com>'s request for review:
Bug 192241: [ews-app] Run BugzillaPatchFetcher periodically
https://bugs.webkit.org/show_bug.cgi?id=192241

Attachment 356393: Proposed patch

https://bugs.webkit.org/attachment.cgi?id=356393&action=review




--- Comment #2 from Lucas Forschler <lforschler at apple.com> ---
Comment on attachment 356393
  --> https://bugs.webkit.org/attachment.cgi?id=356393
Proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=356393&action=review

lgtm, with a fixme.

> Tools/BuildSlaveSupport/ews-app/ews/apps.py:30
> +

Please add a todo for this:
https://stackoverflow.com/questions/33814615/how-to-avoid-appconfig-ready-metho
d-running-twice-in-django


More information about the webkit-reviews mailing list