[webkit-reviews] review granted: [Bug 191806] Web Content process main thread blocked beneath ImageDecoderAVFObjC::readSamples for many seconds on imgur.com : [Attachment 356407] Patch

[bugzilla-daemon at webkit.org]

Dean Jackson <dino at apple.com> has granted Jer Noble <jer.noble at apple.com>'s
request for review:
Bug 191806: Web Content process main thread blocked beneath
ImageDecoderAVFObjC::readSamples for many seconds on imgur.com
https://bugs.webkit.org/show_bug.cgi?id=191806

Attachment 356407: Patch

https://bugs.webkit.org/attachment.cgi?id=356407&action=review




--- Comment #20 from Dean Jackson <dino at apple.com> ---
Comment on attachment 356407
  --> https://bugs.webkit.org/attachment.cgi?id=356407
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=356407&action=review

> Source/WebCore/PAL/pal/cf/CoreMediaSoftLink.h:262
> +SOFT_LINK_FUNCTION_FOR_HEADER(PAL, CoreMedia,
CMBlockBufferCreateWithMemoryBlock, OSStatus, (CFAllocatorRef
structureAllocator, void* memoryBlock, size_t blockLength, CFAllocatorRef
blockAllocator, const CMBlockBufferCustomBlockSource* customBlockSource, size_t
offsetToData, size_t dataLength, CMBlockBufferFlags flags, CMBlockBufferRef*
blockBufferOut), (structureAllocator, memoryBlock, blockLength, blockAllocator,
customBlockSource, offsetToData, dataLength, flags, blockBufferOut))
> +#define CMBlockBufferCreateWithMemoryBlock
softLink_CoreMedia_CMBlockBufferCreateWithMemoryBlock

Can we remove the things that you replaced from this file? e.g.
allocAVAssetReaderTrackOutputInstance?