[webkit-reviews] review granted: [Bug 192348] Regression(r238817) PSON Page Cache API tests are failing : [Attachment 356455] Patch

[bugzilla-daemon at webkit.org]

Alex Christensen <achristensen at apple.com> has granted Chris Dumez
<cdumez at apple.com>'s request for review:
Bug 192348: Regression(r238817) PSON Page Cache API tests are failing
https://bugs.webkit.org/show_bug.cgi?id=192348

Attachment 356455: Patch

https://bugs.webkit.org/attachment.cgi?id=356455&action=review




--- Comment #8 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 356455
  --> https://bugs.webkit.org/attachment.cgi?id=356455
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=356455&action=review

> Source/WebCore/page/MemoryRelease.h:32
> +enum class MaintainPageCache { No, Yes };

: bool

> Source/WebKit/WebProcess/WebProcess.cpp:284
> +	       auto maintainPageCache = m_isSuspending &&
hasPageRequiringPageCacheWhileSuspended() ? WebCore::MaintainPageCache::Yes :
WebCore::MaintainPageCache::No;

Will m_isSuspending really be true during web process initialization?