[webkit-reviews] review denied: [Bug 192352] Remove using namespace WebCore and WebKit under WebKit/Shared/API : [Attachment 356473] Patch

[bugzilla-daemon at webkit.org]

Alex Christensen <achristensen at apple.com> has denied Fujii Hironori
<Hironori.Fujii at sony.com>'s request for review:
Bug 192352: Remove using namespace WebCore and WebKit under WebKit/Shared/API
https://bugs.webkit.org/show_bug.cgi?id=192352

Attachment 356473: Patch

https://bugs.webkit.org/attachment.cgi?id=356473&action=review




--- Comment #6 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 356473
  --> https://bugs.webkit.org/attachment.cgi?id=356473
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=356473&action=review

> Source/WebKit/Shared/API/APIURLRequest.cpp:34
> -using namespace WebCore;
> -using namespace WebKit;
> -
>  namespace API {
>  
> -URLRequest::URLRequest(const ResourceRequest& request)
> +URLRequest::URLRequest(const WebCore::ResourceRequest& request)

If you just move the "using namespace X;" to after the "namespace Y {" then the
"using" has that scope, doesn't mess with unified builds, and requires less
invasive changes to the existing code.