[webkit-reviews] review granted: [Bug 192120] Web Inspector: Elements: ⌘-A should select all visible nodes : [Attachment 356450] Patch

[bugzilla-daemon at webkit.org]

Devin Rousso <drousso at apple.com> has granted Matt Baker <mattbaker at apple.com>'s
request for review:
Bug 192120: Web Inspector: Elements: ⌘-A should select all visible nodes
https://bugs.webkit.org/show_bug.cgi?id=192120

Attachment 356450: Patch

https://bugs.webkit.org/attachment.cgi?id=356450&action=review




--- Comment #3 from Devin Rousso <drousso at apple.com> ---
Comment on attachment 356450
  --> https://bugs.webkit.org/attachment.cgi?id=356450
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=356450&action=review

r=me

> Source/WebInspectorUI/ChangeLog:10
> +	   (WI.TreeOutline.prototype._treeKeyDown):

You should add a comment explaining how by removing the early-return, you allow
`WI.SelectionController` to handle the ⌘-A and select all items.