[webkit-reviews] review granted: [Bug 192346] Web Inspector: Audit: save the expanded state of test groups : [Attachment 356449] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Dec 3 20:32:21 PST 2018


Matt Baker <mattbaker at apple.com> has granted Devin Rousso <drousso at apple.com>'s
request for review:
Bug 192346: Web Inspector: Audit: save the expanded state of test groups
https://bugs.webkit.org/show_bug.cgi?id=192346

Attachment 356449: Patch

https://bugs.webkit.org/attachment.cgi?id=356449&action=review




--- Comment #4 from Matt Baker <mattbaker at apple.com> ---
Comment on attachment 356449
  --> https://bugs.webkit.org/attachment.cgi?id=356449
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=356449&action=review

r=me

> Source/WebInspectorUI/UserInterface/Views/AuditTreeElement.js:54
> +	       this._expandedSetting = new WI.Setting("audit-tree-element-" +
this.representedObject.name + "-expanded", false);

How about using a template string?

`audit-tree-element-${this.representedObject.name}-expanded`


More information about the webkit-reviews mailing list