[webkit-reviews] review requested: [Bug 192248] Web Inspector: REGRESSION(r238330): Timeline auto-capture does not work after page transition : [Attachment 356434] [PATCH] Proposed Fix

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Dec 3 16:43:48 PST 2018


Joseph Pecoraro <joepeck at webkit.org> has asked	for review:
Bug 192248: Web Inspector: REGRESSION(r238330): Timeline auto-capture does not
work after page transition
https://bugs.webkit.org/show_bug.cgi?id=192248

Attachment 356434: [PATCH] Proposed Fix

https://bugs.webkit.org/attachment.cgi?id=356434&action=review




--- Comment #6 from Joseph Pecoraro <joepeck at webkit.org> ---
Created attachment 356434

  --> https://bugs.webkit.org/attachment.cgi?id=356434&action=review

[PATCH] Proposed Fix

Issue was when we were starting the legacy recording we hadn't yet transitioned
the frame, so the old main resource (with old start time) was included with all
the new resources after navigation. This change starts the legacy recording
after we've transitioned main resources so all the resources included in the
recording are from the new page.


More information about the webkit-reviews mailing list