[webkit-reviews] review granted: [Bug 192069] Implement non-timeslice mode encoding for MediaRecorder : [Attachment 356405] Patch

[bugzilla-daemon at webkit.org]

youenn fablet <youennf at gmail.com> has granted Wendy <yuhan_wu at apple.com>'s
request for review:
Bug 192069: Implement non-timeslice mode encoding for MediaRecorder
https://bugs.webkit.org/show_bug.cgi?id=192069

Attachment 356405: Patch

https://bugs.webkit.org/attachment.cgi?id=356405&action=review




--- Comment #26 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 356405
  --> https://bugs.webkit.org/attachment.cgi?id=356405
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=356405&action=review

> Source/WebCore/Modules/mediarecorder/MediaRecorder.cpp:39
>  #include "MediaRecorderPrivateMock.h"

"MediaRecorderPrivateMock.h" is probably not needed anymore.

We usually put COCOA specific includes at the end of the list, separated by a
line.

> Source/WebCore/Modules/mediarecorder/MediaRecorder.cpp:75
> +    , m_private(MediaRecorder::getPrivateImpl(m_stream->privateStream()))

As of a follow-up patch, we might want to create the MediaRecorderPrivate first
in MediaRecorder::create and then only create MediaRecorder if we have a valid
private.

> Source/WebCore/platform/mediarecorder/MediaRecorderPrivateAVFImpl.cpp:41
> +    auto AVImpl = std::unique_ptr<MediaRecorderPrivateAVFImpl>(new
MediaRecorderPrivateAVFImpl(stream));

s/AVImpl/instance

> Source/WebCore/platform/mediarecorder/MediaRecorderPrivateAVFImpl.cpp:42
> +    if (!AVImpl->isWriterReady)

s/isWriterReady/m_isWriterReady/