[webkit-reviews] review denied: [Bug 192105] Web Inspector: Audit: "Add Default Audits" shown when there are no filter results : [Attachment 355922] Patch

[bugzilla-daemon at webkit.org]

Matt Baker <mattbaker at apple.com> has denied Devin Rousso <drousso at apple.com>'s
request for review:
Bug 192105: Web Inspector: Audit: "Add Default Audits" shown when there are no
filter results
https://bugs.webkit.org/show_bug.cgi?id=192105

Attachment 355922: Patch

https://bugs.webkit.org/attachment.cgi?id=355922&action=review




--- Comment #5 from Matt Baker <mattbaker at apple.com> ---
Comment on attachment 355922
  --> https://bugs.webkit.org/attachment.cgi?id=355922
Patch

r-, due to some issues that came up during testing:

Before applying patch:
- I can't reproduce the bug: when I filter the sidebar "No Filter Results" is
always shown.
- It looks like "Add Default Audits" isn't shown after removing all audits from
the sidebar.

After applying patch:
- "Add Default Audits" works now.
- After removing all audits, adding filter text causes "No Filter Results" to
be shown again. Clearing the filter text does not remove the message, and there
is no way to add the default audits.