[webkit-reviews] review granted: [Bug 192303] [iOS] Handle hit testing for subframes : [Attachment 356365] Patch (applies on top of bug 173833)

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Dec 3 14:01:19 PST 2018


Simon Fraser (smfr) <simon.fraser at apple.com> has granted Frédéric Wang (:fredw)
<fred.wang at free.fr>'s request for review:
Bug 192303: [iOS] Handle hit testing for subframes
https://bugs.webkit.org/show_bug.cgi?id=192303

Attachment 356365: Patch (applies on top of bug 173833)

https://bugs.webkit.org/attachment.cgi?id=356365&action=review




--- Comment #2 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 356365
  --> https://bugs.webkit.org/attachment.cgi?id=356365
Patch (applies on top of bug 173833)

View in context: https://bugs.webkit.org/attachment.cgi?id=356365&action=review

> Source/WebCore/page/FrameView.h:682
> +    bool coordinateChangeShouldIgnoreScrollPosition() const final;

Please rename this to windowToContentsShouldIgnoreScrollPosition()


More information about the webkit-reviews mailing list