[webkit-reviews] review granted: [Bug 192318] Update process assertions after swapping processes : [Attachment 356395] Patch

[bugzilla-daemon at webkit.org]

Chris Dumez <cdumez at apple.com> has granted Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 192318: Update process assertions after swapping processes
https://bugs.webkit.org/show_bug.cgi?id=192318

Attachment 356395: Patch

https://bugs.webkit.org/attachment.cgi?id=356395&action=review




--- Comment #3 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 356395
  --> https://bugs.webkit.org/attachment.cgi?id=356395
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=356395&action=review

> Source/WebKit/ChangeLog:10
> +	   after navigation and process swapping we need the new WebProcess to
update its process assertions.

typo: and process swapping -> and *after* ?

> Source/WebKit/UIProcess/Cocoa/NavigationState.mm:1232
> +    // Take the process assertion from the old web process.

I would say:
// Transfer our background assertion from the old process to the new one.