[webkit-reviews] review granted: [Bug 192306] [SOUP] Move URLSoup back to WebCore after r238771 : [Attachment 356372] Patch

[bugzilla-daemon at webkit.org]

Michael Catanzaro <mcatanzaro at igalia.com> has granted Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 192306: [SOUP] Move URLSoup back to WebCore after r238771
https://bugs.webkit.org/show_bug.cgi?id=192306

Attachment 356372: Patch

https://bugs.webkit.org/attachment.cgi?id=356372&action=review




--- Comment #2 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Comment on attachment 356372
  --> https://bugs.webkit.org/attachment.cgi?id=356372
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=356372&action=review

Thanks, good catch. Looks like this was not fun to fix.

> Source/WebKit/PluginProcess/PluginProcess.cpp:42
> +#include <unistd.h>

Probably this belongs inside an OS(UNIX) guard.