[webkit-reviews] review granted: [Bug 192312] [iOS] Add logging channel for hover related content observation : [Attachment 356383] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted zalan
<zalan at apple.com>'s request for review:
Bug 192312: [iOS] Add logging channel for hover related content observation
https://bugs.webkit.org/show_bug.cgi?id=192312

Attachment 356383: Patch

https://bugs.webkit.org/attachment.cgi?id=356383&action=review




--- Comment #2 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 356383
  --> https://bugs.webkit.org/attachment.cgi?id=356383
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=356383&action=review

> Source/WebCore/dom/Document.cpp:1800
> +	   LOG_WITH_STREAM(ContentObservationForHover, stream <<
"Document::scheduleStyleRecalc: register this style recalc schedule and observe
when it fires.");

Print document address.

> Source/WebCore/dom/Document.cpp:2042
> +	   LOG_WITH_STREAM(ContentObservationForHover, stream <<
"Document::scheduleStyleRecalc: start observing content change.");

Ditto.

> Source/WebCore/dom/Document.cpp:2637
> +	   LOG_WITH_STREAM(ContentObservationForHover, stream <<
"Document::platformSuspendOrStopActiveDOMObjects: remove registered timers.");

Print the document address

> Source/WebCore/platform/Logging.h:59
> +    M(ContentObservationForHover) \

ContentObservation. Please keep alphabetized.

> Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm:557
> +	   LOG_WITH_STREAM(ContentObservationForHover, stream <<
"handleSyntheticClick: Observerd meaningful visible change -> hover.");

Observerd