[webkit-reviews] review granted: [Bug 192287] Use WallTime for file time : [Attachment 356376] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Yusuke Suzuki
<yusukesuzuki at slowstart.org>'s request for review:
Bug 192287: Use WallTime for file time
https://bugs.webkit.org/show_bug.cgi?id=192287

Attachment 356376: Patch

https://bugs.webkit.org/attachment.cgi?id=356376&action=review




--- Comment #7 from Darin Adler <darin at apple.com> ---
Comment on attachment 356376
  --> https://bugs.webkit.org/attachment.cgi?id=356376
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=356376&action=review

> Source/WebCore/fileapi/File.cpp:116
> +    if (modificationTime && !std::isnan(modificationTime.value()))

Do we need to allow FileSystem::getFileModificationTime implementations to
return NAN instead of std::nullopt? If so, what is the distinct meaning of the
NAN?