[webkit-reviews] review granted: [Bug 191926] [EME][ClearKey] Add layout test for dynamic change of key and video resolution : [Attachment 355727] Patch

[bugzilla-daemon at webkit.org]

Xabier Rodríguez Calvar <calvaris at igalia.com> has granted Yacine Bandou
<bandou.yacine at gmail.com>'s request for review:
Bug 191926: [EME][ClearKey] Add layout test for dynamic change of key and video
resolution
https://bugs.webkit.org/show_bug.cgi?id=191926

Attachment 355727: Patch

https://bugs.webkit.org/attachment.cgi?id=355727&action=review




--- Comment #11 from Xabier Rodríguez Calvar <calvaris at igalia.com> ---
Comment on attachment 355727
  --> https://bugs.webkit.org/attachment.cgi?id=355727
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=355727&action=review

>
LayoutTests/media/encrypted-media/clearKey/clearKey-cenc-video-playback-mse-mul
tikey.html:26
> +	       else {
> +		   if (video.currentTime >= 4) {

This can be an else if

>
LayoutTests/media/encrypted-media/clearKey/clearKey-cenc-video-playback-mse-mul
tikey.html:27
> +		   if (video.currentTime >= 4) {
> +		       testExpected("video.currentTime", 4, ">=")

No strong opinion on this, just looks a bit weird to me.