[webkit-reviews] review denied: [Bug 192248] Web Inspector: REGRESSION(r238330): Timeline auto-capture does not work after page transition : [Attachment 356273] [PATCH] Proposed Fix

[bugzilla-daemon at webkit.org]

Devin Rousso <drousso at apple.com> has denied Joseph Pecoraro
<joepeck at webkit.org>'s request for review:
Bug 192248: Web Inspector: REGRESSION(r238330): Timeline auto-capture does not
work after page transition
https://bugs.webkit.org/show_bug.cgi?id=192248

Attachment 356273: [PATCH] Proposed Fix

https://bugs.webkit.org/attachment.cgi?id=356273&action=review




--- Comment #3 from Devin Rousso <drousso at apple.com> ---
Comment on attachment 356273
  --> https://bugs.webkit.org/attachment.cgi?id=356273
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=356273&action=review

r-, as this causes a different issue.  Using the same reproduction steps, when
navigating to <https://apple.com>, auto-capture starts, but no records are
shown other than the initial heap snapshot and the main frame network entry.

> Source/WebInspectorUI/UserInterface/Controllers/TimelineManager.js:68
> +	   if (target.TimelineAgent) {

Style: early-return if this is false.

> Source/WebInspectorUI/UserInterface/Controllers/TimelineManager.js:80
> +	      
this._legacyAttemptStartAutoCapturingForFrame(WI.networkManager.mainFrame);

As far as I understand, this is only needed if
`target.TimelineAgent.setAutoCaptureEnabled` isn't supported.  Should we be
using `_attemptAutoCapturingForFrame` instead?

    transitionPageTarget()
    {
	this._attemptAutoCapturingForFrame(WI.networkManager.mainFrame);
    }