[webkit-reviews] review granted: [Bug 179903] [ESNext][BigInt] Support logic operations : [Attachment 355865] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Dec 2 00:40:00 PST 2018

Yusuke Suzuki <yusukesuzuki at slowstart.org> has granted Caio Lima
<ticaiolima at gmail.com>'s request for review:
Bug 179903: [ESNext][BigInt] Support logic operations

Attachment 355865: Patch


--- Comment #16 from Yusuke Suzuki <yusukesuzuki at slowstart.org> ---
Comment on attachment 355865
  --> https://bugs.webkit.org/attachment.cgi?id=355865

View in context: https://bugs.webkit.org/attachment.cgi?id=355865&action=review

r=me with nits.

> Source/JavaScriptCore/runtime/JSBigInt.cpp:1680
> +bool JSBigInt::toBoolean() const
> +{
> +    return !isZero();
> +}

This function is very very small. I think we should define `isZero` and
`toBoolean` as inline functions in JSBigInt.h (inside the class JSBigInt

More information about the webkit-reviews mailing list