[webkit-reviews] review granted: [Bug 192271] Fix the bytecode code generator scripts to pretty print BytecodeStructs.h and BytecodeIndices.h. : [Attachment 356271] proposed patch.

[bugzilla-daemon at webkit.org]

Keith Miller <keith_miller at apple.com> has granted Mark Lam
<mark.lam at apple.com>'s request for review:
Bug 192271: Fix the bytecode code generator scripts to pretty print
BytecodeStructs.h and BytecodeIndices.h.
https://bugs.webkit.org/show_bug.cgi?id=192271

Attachment 356271: proposed patch.

https://bugs.webkit.org/attachment.cgi?id=356271&action=review




--- Comment #2 from Keith Miller <keith_miller at apple.com> ---
Comment on attachment 356271
  --> https://bugs.webkit.org/attachment.cgi?id=356271
proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=356271&action=review

r=me

> Source/JavaScriptCore/generator/Opcode.rb:208
> +#{@metadata.struct(self)}#{@metadata.accessor}

Shouldn’t there be a new line between these?

> Source/JavaScriptCore/generator/Opcode.rb:214
> +#{print_members("	", &:field)}#{@metadata.field("    ")}

Ditto.