[webkit-reviews] review granted: [Bug 192203] [JSC] Keep TypeMaybeBigInt small : [Attachment 356097] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Dec 1 00:21:10 PST 2018


Saam Barati <sbarati at apple.com> has granted Yusuke Suzuki
<yusukesuzuki at slowstart.org>'s request for review:
Bug 192203: [JSC] Keep TypeMaybeBigInt small
https://bugs.webkit.org/show_bug.cgi?id=192203

Attachment 356097: Patch

https://bugs.webkit.org/attachment.cgi?id=356097&action=review




--- Comment #4 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 356097
  --> https://bugs.webkit.org/attachment.cgi?id=356097
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=356097&action=review

> Source/JavaScriptCore/parser/ResultType.h:35
> +	   static constexpr Type TypeInt32	 = 0x1 << 0;

style nit: iā€™m not sure if this is a UI issue in bugzilla, but this line is the
only line without the ā€œ=ā€œ lined up. We should align it


More information about the webkit-reviews mailing list