[webkit-reviews] review granted: [Bug 189216] Added functionality to encode and decode a uint64_t in KeyedCoding : [Attachment 348691] Patch

[bugzilla-daemon at webkit.org]

Daniel Bates <dbates at webkit.org> has granted Woodrow Wang
<wwang153 at stanford.edu>'s request for review:
Bug 189216: Added functionality to encode and decode a uint64_t in KeyedCoding
https://bugs.webkit.org/show_bug.cgi?id=189216

Attachment 348691: Patch

https://bugs.webkit.org/attachment.cgi?id=348691&action=review




--- Comment #3 from Daniel Bates <dbates at webkit.org> ---
Comment on attachment 348691
  --> https://bugs.webkit.org/attachment.cgi?id=348691
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=348691&action=review

> Source/WebCore/ChangeLog:3
> +	   Added functionality to encode and decode a uint64_t in KeyedCoding. 

This line should be a verbatim copy of the bug title. Please remove the period.

> Source/WebCore/ChangeLog:7
>  

Please explain why you are adding this functionality given that this patch just
adds infrastructure and does not make use of it.

> Source/WebCore/ChangeLog:22
> +2018-08-31  Woodrow Wang  <woodrow_wang at apple.com>

Please fix up this file such that it only contains a new change log entry at
the top.